dotnet / dotnet/msbuild

Fleaky test ResponseFileSwitchesAppearInCommandLine

Open
#8,946 0 comments 0 reactions 0 assignees View on GitHub
triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 13h
Merged PRs (30d)
133

Description

### Context

Failing CI test on Mac

```
Shouldly.ShouldAssertException : \"MSBUILD : error MSB1060: Undefined environment variable passed in as switch.\r\n Full command line:...\"\n should contain (case insensitive comparison)\n\": %NONEXISTENTENVIRONMENTVARIABLE%\"\n but did not
```

Full output of the test

```
MSBUILD : error MSB1060: Undefined environment variable passed in as switch.
Full command line: '/Users/runner/work/1/s/artifacts/bin/Microsoft.Build.CommandLine.UnitTests/Debug/net7.0/MSBuild.dll project.proj -nologo'
Switches appended by response files:
'' came from '/Users/runner/work/1/s/artifacts/bin/Microsoft.Build.CommandLine.UnitTests/Debug/net7.0/MSBuild.rsp'
'' came from '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/jol2i3fv.gsq/Directory.Build.rsp'
'-nowarn:MSB1001 @myRsp.rsp %NONEXISTENTENVIRONMENTVARIABLE%' came from '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/jol2i3fv.gsq/MSBuildTemprunner/Temporary02d0d4329a7440e5a9b6306760054ce9/MSBuild.rsp'
'-nr:false -m:2' came from '/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/jol2i3fv.gsq/MSBuildTemprunner/Temporary02d0d4329a7440e5a9b6306760054ce9/myRsp.rsp'
```

Unexpectedly missing:

```
Switch: %NONEXISTENTENVIRONMENTVARIABLE%

For switch syntax, type "MSBuild -help"

```

so it looks like `CommandLineSwitchException` was not thrown

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating and running the ResponseFileSwitchesAppearInCommandLine test, focusing on the Mac CI output and response-file command-line parsing. Done means the test reliably throws CommandLineSwitchException and its assertion includes %NONEXISTENTENVIRONMENTVARIABLE% on Mac.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.