dotnet / dotnet/msbuild

"Resolving SDK" messages aren't attributed to an evaluation

Open
#8,639 1 comment 1 reaction 0 assignees View on GitHub
Area: Logging backlog bug triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 13h
Merged PRs (30d)
133

Description

### Issue Description

@KirillOsenkov was looking at an internal build failure that was hard to diagnose, in part because the Resolving SDK events aren't parented under any particular project evaluation

### Steps to Reproduce

https://github.com/dotnet/msbuild/issues/7988 should show these symptoms too.

### Expected Behavior

If SDK resolution fails, all of the messages should be attributed to a project, so it's easier to understand what was looking for the SDK and any progress messages/warnings associated with it.

### Actual Behavior

![image](https://user-images.githubusercontent.com/3347530/230182968-168b8d6b-c64a-42d1-9615-ecfb0f7f0425.png)

### Analysis

This may be caused by the desire to single-instance SDK resolution for a build, so the actual resolution is happening in one thread while other things wait on it.

### Versions & Configurations

_No response_

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the behavior using dotnet/msbuild#7988 and inspect the SDK resolution and project-evaluation event handling. Trace how SDK resolution messages are emitted and determine how they can remain associated with the project evaluation that requested them. Done means resolution failures, progress messages, and warnings are attributed to the relevant project evaluation.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.