dotnet / dotnet/msbuild

WriteOnlyWhenDifferent should check with the same encoding

Open
#8,361 1 comment 0 reactions 1 assignee Claimed by @stan-sz View on GitHub
Area: Tasks backlog help wanted Partner request triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

The encoding is missing on the check for `WriteOnlyWhenDifferent`
https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L102
while it's present on the subsequent write: https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L121

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.