dotnet / dotnet/msbuild

Diagnostic build log not emitting properties anymore?

Open
#6,609 17 comments 0 reactions 0 assignees View on GitHub
Area: Logging bug triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 13h
Merged PRs (30d)
133

Description

### Issue Description

We first noticed this through Maestro bumps:

* https://github.com/xamarin/xamarin-android/pull/6029
* https://github.com/xamarin/xamarin-android/pull/6034

We have a unit test that is asserting several MSBuild properties are in the diagnostic MSBuild log:

[build.zip](https://github.com/dotnet/msbuild/files/6697116/build.zip)

It's looking for text like `AndroidSdkBuildToolsVersion = `. I see this as parameters to tasks, but that's it.

That's when I noticed I'm seeing env vars in this log but not properties? Did we regress on that? Thanks!

### Steps to Reproduce

I think, just build a project with `/flp1:LogFile=build.log;Verbosity=diag` and look for properties in the file?

### Expected Behavior

Properties are in diagnostic build logs.

### Actual Behavior

I don't see properties in diagnostic build logs?

### Versions & Configurations

.NET 6.0.100-preview.6.21321.13

### Attach a binlog

I don't really see properties in here either:

[msbuild.zip](https://github.com/dotnet/msbuild/files/6697156/msbuild.zip)

Contributor guide

No contributing guide indexed for this repository

Research direction

No source file or test is named. Reproduce with a project build using `/flp1:LogFile=build.log;Verbosity=diag`, then compare the diagnostic log and attached binlog for MSBuild properties such as `AndroidSdkBuildToolsVersion`. Done means diagnostic build logs emit the expected properties again.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.