dotnet / dotnet/msbuild

Consumption of SkipEagerWildcardEvaluations in VS blocked on exclude bugs

Open
#6,388 2 comments 0 reactions 0 assignees View on GitHub
Area: Performance backlog bug CPS triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

From the VS side, we see about 3-3.5% in solution load gains when using _SkipEagerWildcardEvaluations_ . But Mihai mentioned the below where there are potential bugs in that codepath that would need to be cleared out for consumption.

_As far as I remember if you have Include=”*.cs” Exclude=”foo.cs”, if *.cs is expanded lazily then it won’t apply the exclude pattern and hence the glob result will have foo.cs. IIRC this happens because lazy expansion is implemented deep inside the Evaluator when it reads an item, at which point all the details about the item element that produced that item (like the contents of the Exclude attribute) are lost. It’s not obvious to me how to fix this without doing a deep dive into the code._

Consider adding this to your backlog of VS requests. Given how old the codebase is, I’m of the opinion that we should try and chase down any areas we know there are gains, because it’s more likely for us to get a lot of small gains than 1 big gain, unless there is a huge codebase rewrite.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.