dotnet / dotnet/msbuild

Certain Tests Leave Hanging Processes

Open
#6,344 0 comments 0 reactions 0 assignees View on GitHub
Area: Our Own Build bug testing triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 6h
Merged PRs (30d)
139

Description

### Issue Description
Discovered when [opting into perf logging](https://github.com/dotnet/msbuild/pull/6274).

There are certain tests that when run leave a hanging `VBCSCompiler` and `MSBuild` processes.

### Steps to Reproduce
Run any of the following tests and use procexp to see leftover processes:
- `StopOnFirstFailureandBuildInParallelMultipleNode`
- `PropertyOverrideContainsSemicolon`
- Any test under `TargetsFile_Test`

### Expected Behavior
Leftover processes should be cleaned up.

### Actual Behavior
Processes are leftover after the test runs.

### Analysis
Rainer pointed out we may be able to kill all child processes when our xunit classes get disposed of.
https://github.com/dotnet/msbuild/blob/main/src/Shared/UnitTests/TestAssemblyInfo.cs#L116

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.