dotnet / dotnet/msbuild

Comment in code about nuget sdk resolver references unused nuget path

Open
#5,394 0 comments 0 reactions 0 assignees View on GitHub
triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

### Steps to reproduce

According to the comment and code here, we load nuget assemblies at runtime and use this environment variable to overload that. However, according to Rainer, that's no longer used and so it appears this exception and the underlying nuget path variable should be removed.
https://github.com/microsoft/msbuild/blob/b4f5792a8fadab87e5199ec54d355c3ba1397a6a/src/Build/BackEnd/Components/SdkResolution/SdkResolverService.cs#L120-L129

### Expected behavior
Remove that exception, the comment, and the NuGetAssemblyPathEnvironmentVariableName definition.

### Actual behavior
A confusing and incorrect error.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.