dotnet / dotnet/msbuild

Improve ConstructDependencyTable on many input files

Open
#5,393 0 comments 0 reactions 0 assignees View on GitHub
Area: FileTracker Area: Performance triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

Spiritual successor to #5180

See https://github.com/microsoft/msbuild/issues/5180#issuecomment-635085646

> Could also take a look at the Constructor? I stopwatched it taking 400ms (while not as much as RemoveDependenciesFromEntryIfMissing()), I expected it to take only 40-50ms. I refactored disk access from the timer and it still took the same time, thus issue is somewhere else.

> edit I should add when I say Constructor() I really meant the function ConstructDependencyTable(). This inner loop is also a great candidate for parallel foreach.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.