dotnet / dotnet/msbuild

Use Hash Combiner for Node Handshake Logic

Open
#4,960 2 comments 0 reactions 0 assignees View on GitHub
triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

Our current hash combining functionality for node handshakes results in communication issues.

A node communicating from `c:\Users\bevillal\Documents\GitHub\msbuild\artifacts\bin\Microsoft.Build.Engine.UnitTests\Debug\net472\` was able to talk to a node created from `c:\Users\bevillal\Documents\GitHub\msbuild\artifacts\bin\Microsoft.Build.Engine.UnitTests\Debug\net472\amd64\` because they computed the same hash when using their folder paths as part of the handshake.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.