dotnet / dotnet/msbuild

Consider blocking TaskLoggingHelper use after its task ends

Open
#4,828 1 comment 0 reactions 0 assignees View on GitHub
Area: Debuggability help wanted triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 13h
Merged PRs (30d)
133

Description

see https://github.com/microsoft/msbuild/issues/4792#issuecomment-543336926 and the rest of that thread

If you hold onto a `TaskLoggingHelper` object (perhaps in a `static` field) past the lifetime of the `Task` that created it, it will throw when it is used.

We could instead dispose of it and provide a nicer error at time of use.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.