dotnet / dotnet/msbuild

Proposal: Unified Extension points for Imports

Open
#4,539 2 comments 1 reaction 0 assignees View on GitHub
triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

W.R.T to #1686

If we do get a Base SDK and/or a Managed SDK that's above .NET SDK, then I would propose to unify the Import Extensibility points they offer.

#### Base SDK props
- `Directory.Build.props`
- `..Before.props`

#### Any SDK props
- `CustomBeforeProps`
- ``
- `CustomAfterProps`

#### Base SDK props
- `..After.props`

#### Project File
- `CustomImportBeforeProject` / `CustomBefore` / `Custom.Project.props`
- ``
- `CustomImportAfterProject` / `CustomAfter` / `Custom.Project.targets`

#### Base SDK targets
- `..Before.targets`

#### Any SDK targets
- `CustomBeforeTargets`
- ``
- `CustomAfterTargets`

#### Base SDK targets
- `..After.targets`
- `Directory.Build.targets`

**NOTE**: `Custom Before/After` are user extensibility points. They are optional as they depend on the SDK implementers. [MSBuildSdks](/Microsoft/MSBuildSdks) already follows the `Custom` pattern I mentioned above.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.