dotnet / dotnet/msbuild

Should builds issued via IBuildEngine from tasks fail with the "Undeclared reference" check?

Open
#4,385 2 comments 0 reactions 0 assignees View on GitHub
Area: Static Graph triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 13h
Merged PRs (30d)
133

Description

There's two static graph isolation constraints:
1. all referenced projects must be declared before usage
2. there should be no cache misses

Building an undeclared project via the MSBuild task triggers constraint 1., but building a project via the IBuildEngine callback from within a task triggers 2. Should it instead fail with 1. and report which task tried to do it?

This is more of a fit and finish thing, since the build will fail either way. It's just that type 1 failures are easier to understand than type 2. IsolateProjects_Tests has some commented out `InlineData` elements which exercise this path.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.