UndefineProperties metadata is whitespace-sensitive
- Dominant language
- C#
- Stars
- 5.5k
- Forks
- 1.5k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 133
Description
Reported by @jachin84 in https://github.com/Microsoft/msbuild/issues/3990#issuecomment-447823959
> Ok so this seems a little odd. I am using the following in a Directory.Build.props which fails every time because of concurrency issues.
>
> ```xml
>
>
>
> _PackageTempDir;AutoParameterizationWebConfigConnectionStrings
>
>
>
> ```
> If I do the following it work:
>
> ```xml
>
>
> _PackageTempDir;AutoParameterizationWebConfigConnectionStrings
>
>
> ```
> Not the only difference is splitting `UndefineProperties` on different lines.
This should ignore whitespace surrounding property names like other things do.
https://github.com/Microsoft/msbuild/blob/c4796604b9744d17cad2eaf028902af423c60e2f/src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/MSBuild.cs#L250-L260
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/MSBuild.cs at lines 250-260, where UndefineProperties is handled. Compare the multiline and single-line examples, then trace the property-name parsing. Done means surrounding whitespace is ignored consistently, with coverage added or updated for the reported multiline form.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100