dotnet / dotnet/msbuild

ContinueOnError on MSBuild task should not cancel the cache enforcements

Open
#3,876 0 comments 0 reactions 0 assignees View on GitHub
Area: Static Graph bug triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 13h
Merged PRs (30d)
133

Description

If one sets a `ContinueOnError="WarnAndContinue"` on an msbuild task that would fail the cache enforcement otherwise, the build still succeeds.
The msbuild task enforcement on the other hand correctly ignores the `ContinueOnError` setting

Failing test: https://github.com/cdmihai/msbuild/blob/62fb89029dac66f73a5ca52363fd11b36f12190b/src/Build.UnitTests/Graph/IsolateProjects_Tests.cs#L104

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the failing test in src/Build.UnitTests/Graph/IsolateProjects_Tests.cs at line 104 and reproduce the cache-enforcement case using ContinueOnError="WarnAndContinue". Trace the test and related MSBuild task enforcement behavior to understand why the build succeeds. Done means cache enforcement still fails despite ContinueOnError, while the existing task enforcement behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.