dotnet / dotnet/msbuild

Markdown produced by profileevaluation can be invalid

Open
#3,170 1 comment 0 reactions 0 assignees View on GitHub
triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 6h
Merged PRs (30d)
139

Description

`Microsoft.CodeAnalysis.targets` contains the following:

```xml
$(CodeAnalysisRuleSetDirectories);$(CodeAnalysisStaticAnalysisDirectory)\Rule Sets
```

When a build is run with `/profileEvaluation:perf.md` and logs this condition, it emits the following in the `md` file:

```
42627548|32196296|Properties (pass 1)|Microsoft.CodeAnalysis.targets|28|`Condition="'$(CodeAnalysisIgnoreBuiltInRuleSets)'!='true' and
'$(CodeAnalysisStaticAna...`|2|0%|2|0%|185|Condition|
```

This breaks the table layout because of the line break after `and`. The `md` emitter should likely escape some more characters such as `\r` and `\n`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.