dotnet / dotnet/msbuild

Inefficiency in target stack for AfterTargets

Open
#3,042 0 comments 0 reactions 0 assignees View on GitHub
Area: Engine Area: Performance Priority:2 triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

https://github.com/Microsoft/msbuild/blob/f9183fddd15e728d52dbeb4716d1d43f2f5541d4/src/Build/BackEnd/Components/RequestBuilder/TargetBuilder.cs#L416-L431

We shouldn't need to push/pop current when there are no `afterTargets`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.