dotnet / dotnet/msbuild

Improvements to Evaluation Profile data storage

Open
#2,827 0 comments 0 reactions 2 assignees Claimed by @KirillOsenkov View on GitHub
Area: Logging triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

- [ ] No need to store EvaluationPassDescription on entries where IsEvaluationPass == false (it can be recovered by walking the parent chain up)
- [ ] Don't serialize EvaluationDescription at all, derive it from EvaluationPass
- [ ] In BuildEventArgsReader/Writer, no need to write a boolean for HasLine and HasParent, just write the Line (and default to 0) and write the ParentId (and default to 0).
- [ ] On Element description XML do not serialize `xmlns` - junk data, easily recovered
- [ ] NumberOfHits seems to always be 0 in the .binlog?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.