dotnet / dotnet/msbuild

AssignCulture task incorrectly categorizes some EmbeddedResources as culture-specific

Open
#2,724 2 comments 0 reactions 0 assignees View on GitHub
triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

### Steps to reproduce

Create a class library with a file `Index.Id.cshtml` marked as embedded resource.
Build.

Project file
```xml


netcoreapp2.0





PreserveNewest

```

### Expected behavior
Should be part of the embedded resource of the assembly

### Actual behavior
A resource assembly for the `Id` culture is created and this file added to it.

My understanding is that when the `AssignCulture` task runs, it finds `Id` to be a valid culture. I confirmed it by looking at `msbuild.log`.

I could suggest for this task to look into a group properties to skip the files. So I could at least mark the files as non resx.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.