dotnet / dotnet/msbuild

Remove operation should not match against its globs

Open
#2,329 5 comments 0 reactions 0 assignees View on GitHub
Area: Performance backlog triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

Remove operations can reference values, globs, and other items. Its implementation is split in two parts
- Its globs are propagated to past include operations, such that the file walking can backtrack out
- Its values and item references remain with the operation, and are matched against whenever the actual Remove operations needs to execute

However, when the actual Remove operation executes, it still looks at its globs and does Regex matching, in addition to matching its potential values and referenced items. This is unnecessary, since the globs got propagated to past operations. Not matching the globs would also be a test for the lookahead optimization :)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.