dotnet / dotnet/msbuild

CodeTaskFactory error on missing attributes does not contain element name

Open
#2,072 8 comments 1 reaction 0 assignees View on GitHub
help wanted triaged User Experience
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

When using CodeTaskFactory, if a Reference element is missing the Include attribute, or a Using element is missing the Namespace attribute, an error is printed about an empty attribute value.

This error isn't great for a few reasons

1. It doesn't say which element the attribute is on
2. It says "The "Include" attribute has been set but is empty" even when it's *missing*
3. It's emitted at the point the task is _used_, not declared, so the message about the Include attribute is easily confused for referring to the Items passed to the task

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.