dotnet / dotnet/msbuild

C++ Output Window logger switched to ENABLEMPLOGGING and regressed formatting

Open
#1,790 1 comment 0 reactions 1 assignee Claimed by @KirillOsenkov View on GitHub
Area: Logging triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

Repro:
1. Create a new C++ Win32 app with ATL
2. Build

Results in VS 2015 Output Window (note two spaces in front of file names in the log):

```
1>------ Rebuild All started: Project: CPPWin32ConsoleApp, Configuration: Debug Win32 ------
1> stdafx.cpp
1> CPPWin32ConsoleApp.cpp
1> CPPWin32ConsoleApp.vcxproj -> C:\Users\kirillo\Documents\Visual Studio 2015\Projects\CPPWin32ConsoleApp\Debug\CPPWin32ConsoleApp.exe
1> CPPWin32ConsoleApp.vcxproj -> C:\Users\kirillo\Documents\Visual Studio 2015\Projects\CPPWin32ConsoleApp\Debug\CPPWin32ConsoleApp.pdb (Full PDB)
========== Rebuild All: 1 succeeded, 0 failed, 0 skipped ==========
```

Results in VS 2017 output window (note no spaces in front of file names):

```
1>------ Build started: Project: CppWin32Project1, Configuration: Debug Win32 ------
1>stdafx.cpp
1>CppWin32Project1.cpp
1>CppWin32Project1.vcxproj -> c:\users\kirillo\documents\visual studio 2017\Projects\CppWin32Project1\Debug\CppWin32Project1.exe
1>CppWin32Project1.vcxproj -> c:\users\kirillo\documents\visual studio 2017\Projects\CppWin32Project1\Debug\CppWin32Project1.pdb (Partial PDB)
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
```

Before:
![image](https://cloud.githubusercontent.com/assets/679326/23535333/a0159ed8-ff72-11e6-8644-07e38fbfde67.png)

After:
![image](https://cloud.githubusercontent.com/assets/679326/23535336/a44c0a50-ff72-11e6-86e8-d7546c2508a0.png)

The issue seems to appear on Minimal and lower, and only to the output window.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.