dotnet / dotnet/msbuild

Throw an error if the Sdk attribute contains any expandable characters

Open
#1,518 7 comments 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

Right now the Sdk value is treated as a literal string with no expansion. If a user specifies something like:

``` xml

```

Then the value "$(Property1)" is passed to the resolver which would probably return a message stating that it couldn't be found. We should instead check if the value contains expandable characters and throw an invalid project error.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.