dotnet / dotnet/msbuild

Stop ngening SAC assemblies

Open
#14,827 0 comments 0 reactions 0 assignees Claimed by @pieandcakes View on GitHub
Priority:2 triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

Our Visual Studio VSIX currently runs ngen on many assemblies we redistribute that are now (after #14739) used primarily from the Shared Assembly Cache (SAC).

https://github.com/dotnet/msbuild/blob/f8839a065388248b5403b846f224dbcc5f54d999/src/Package/MSBuild.VSSetup/files.swr#L58-L60

We should drop the ngen requests for those assemblies, but leave them so they're loadable by anything that isn't SAC-aware yet.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/Package/MSBuild.VSSetup/files.swr at lines 58-60 and review the ngen entries for assemblies now primarily used from the Shared Assembly Cache. Remove the ngen requests while retaining the assemblies for non-SAC-aware consumers; the open linked pull request is also relevant to the current state of this work.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system, devtools
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.