dotnet / dotnet/msbuild

Regression in non-MT mode: repeated current directory allocation in TaskEnvironment

Open
#14,210 0 comments 0 reactions 1 assignee Claimed by @AR-May View on GitHub
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

A regression was observed in non-MT mode where migrated tasks use `TaskEnvironment` and it repeatedly allocates the current directory during path absolutization. This leads to unnecessary overhead. Suggested fix: lazily cache the directory once per task. If the task uses `TaskEnvironment`, then it is MT aware. It should not thus change the working directory, so there is no need to request it each time for path absolutization.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.