dotnet / dotnet/msbuild

Migrate UnregisterAssembly to multithreaded execution

Open
#13,634 0 comments 0 reactions 0 assignees View on GitHub
Area: Multithreaded triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 13h
Merged PRs (30d)
133

Description

## Background
`UnregisterAssembly` reverses `RegisterAssembly` by unregistering managed assemblies and their type libraries from COM. Like its counterpart, it is `AppDomainIsolatedTaskExtension`, gated on `NETFRAMEWORK && FEATURE_APPDOMAIN`.

## Migration scope
- [ ] Apply `[MSBuildMultiThreadableTask]` (defensive)
- [ ] Implement `IMultiThreadableTask` only if reachable from a multithreaded host
- [ ] Absolutize paths via `TaskEnvironment.GetAbsolutePath()` for: Assemblies items, TypeLibFiles items, AssemblyListFile
- [ ] Use `TaskEnvironment.GetEnvironmentVariable()` for: N/A
- [ ] Use `TaskEnvironment.GetProcessStartInfo()` for: N/A

## Known complexity factors
- AppDomain isolation; `TaskEnvironment` must cross the AppDomain boundary
- Native COM unregistration; mutates registry (`TYPE_E_REGISTRYACCESS` handling)
- NETFRAMEWORK-only — multithreaded mode unlikely to ever exercise this code
- Globally serialized in practice due to registry mutation

## Exit criteria
- [ ] Build clean, no new warnings
- [ ] Existing tests pass
- [ ] No regression in error message paths (Sin 2 audit)
- [ ] No leakage of absolutized paths into [Output] properties (Sin 1 audit)

## References
- Parent: #11834
- Migration skill: .github/skills/multithreaded-task-migration/SKILL.md

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.