dotnet / dotnet/msbuild

RequiredRuntimeAttribute is ignored and could be deleted

Open
#13,046 0 comments 1 reaction 2 assignees Claimed by @jaredpar View on GitHub
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

https://github.com/dotnet/msbuild/blob/4618ab514861c1aec4e9a5550ce685590de44bc7/src/Framework/RequiredRuntimeAttribute.cs#L10-L18

This is part of the public API surface, but is used in only one place in our repo

https://github.com/dotnet/msbuild/blob/4618ab514861c1aec4e9a5550ce685590de44bc7/src/Tasks/GenerateResource.cs#L55-L56

And doesn't seem to be respected anywhere (e.g. nothing inspects for that attribute and behaves differently).

I think it's an older design for what eventually got implemented with UsingTask/magic task parameters for runtime, and could be removed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.