dotnet / dotnet/msbuild

Use current runtime + architecture for GenerateResource on .NET Core

Open
#1,293 2 comments 1 reaction 0 assignees View on GitHub
.NET Core bug help wanted triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

See https://github.com/dotnet/sdk/issues/346#issuecomment-257654120.

On .NET Core, MSBuild doesn't support task hosts of different architectures/runtime versions. But the `CoreResGen` target does [some gymnastics](https://github.com/Microsoft/msbuild/blob/4e405a802d587368581117daf3402491beea8de7/src/XMakeTasks/Microsoft.Common.CurrentVersion.targets#L2785-L2809) to figure out the right architecture/runtime version to use for the `GenerateResource` task.

On .NET Core we should just use `CurrentArchitecture`/`CurrentRuntime`.

Or as @nguerrera suggested, maybe just add the `DoesTaskHostExist` check for Architecture as well as Runtime.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.