dotnet / dotnet/msbuild

add a lookup table to TaskExecutionHost.cs

Open
#12,056 0 comments 1 reaction 1 assignee Assigned to @Copilot View on GitHub
Area: Performance Priority:2 triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

During a review discussion for [PR that optimizes TaskExecutionHost](https://github.com/dotnet/msbuild/pull/11959)
We've come to conclusion that it is a step in a good direction, however there is a further improvement to be had: https://github.com/dotnet/msbuild/pull/11959#discussion_r2130610820

We can skip `string key = "DisableLogTaskParameter_" + _taskName + "_" + parameter.Name;` which allocates by instead building a lookup table when we have the available set of tasks and parameter names and then fetching the strings from there.

Task:
build said lookup table to lower the allocations on the hot path further.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.