dotnet / dotnet/msbuild

Add fast-paths for property functions used in template projects

Open
#12,024 0 comments 1 reaction 2 assignees Assigned to @rainersigwald View on GitHub
Area: Performance
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

When building a template classlib in .NET 10.0.100-preview.5, there are two property functions that don't have a fast path, according to the output from enabling the tracing

https://github.com/dotnet/msbuild/blob/aee43cf63f9f9cbab52202fb7aa60dafc1be7f07/src/Build/Evaluation/Expander/WellKnownFunctions.cs#L905

The log is:

```
ReceiverType=Microsoft.Build.Utilities.ToolLocationHelper; ObjectInstanceType=; MethodName=GetPlatformSDKLocation(String, String)
ReceiverType=Microsoft.Build.Utilities.ToolLocationHelper; ObjectInstanceType=; MethodName=GetPlatformSDKDisplayName(String, String)
```

Each of these should get a fast path in `src/Build/Evaluation/Expander/WellKnownFunctions.cs`, following the conventions established in that file.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.