dotnet / dotnet/msbuild

Consider removing custom TaskFactory support

Open
#11,945 0 comments 0 reactions 0 assignees View on GitHub
Area: Engine Breaking Change triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

It is a very niche feature with unclear use-case https://github.com/search?q=%22%3A+ITaskFactory%22+language%3AC%23+Microsoft.Build.Framework&type=code, that assumes runtime of it's tasks in-process, which is dangerous when we're refactoring MSBuild to multithreaded execution https://github.com/dotnet/msbuild/issues/11914

The model now is that Initialize creates an in memory assembly of an ITask and TaskExecutionHost can instantiate it. An in-memory assembly can't travel to an TaskHost node process.

Alternative: breaking change of assumption that it must produce temporary assets/dll in ``, the task can be loaded from that dll in another process and `` will be purged after build.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.