dotnet / dotnet/msbuild

Common.targets doesn't promote TreatWarningsAsErrors to MSBuildTreatWarningsAsErrors

Open
#10,871 17 comments 2 reactions 2 assignees Claimed by @SimaTian View on GitHub
Priority:1 triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

Common.targets does respect the "plain property" version of some warning-related settings:

https://github.com/dotnet/msbuild/blob/69b3e7a43fb2fb26812b20807333cf6ca62167f2/src/Tasks/Microsoft.Common.CurrentVersion.targets#L668-L672

but it doesn't do the broader setting `MSBuildTreatWarningsAsErrors` in the same way.

This adds to the confusion about which settings to use.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.