dotnet / dotnet/msbuild

[Proposal]: Throw ObjectDisposedException when appropriate

Open
#10,648 0 comments 4 reactions 0 assignees View on GitHub
Area: Debuggability internal-team-onboarding Priority:3 triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

Inspired by this [comment](https://github.com/dotnet/msbuild/issues/10320#issuecomment-2340988345). It looks like we are not using `ObjectDisposedException` when we should. This exception indicates exactly why the operation couldn't be completed and reduces confusion. We should throw this exception at least in public disposable types.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.