dotnet / dotnet/msbuild

ToolLocationHelper property functions require reflection

Open
#10,411 0 comments 0 reactions 0 assignees View on GitHub
Area: Engine Area: Performance backlog Priority:3 triaged
Dominant language
C#
Stars
5.5k
Forks
1.5k
Avg merge
1d 8h
Merged PRs (30d)
141

Description

Follow up to #10398.

The following members are invoked on a `dotnet build` and/or `dotnet publish` of the console and web templates and forced to fallback to the reflection-based lookups:

| ReceiverType | ObjectInstanceType | MethodName |
| --- | --- | --- |
| Microsoft.Build.Utilities.ToolLocationHelper| | GetPlatformSDKLocation(String, String) |
| Microsoft.Build.Utilities.ToolLocationHelper| | GetPlatformSDKDisplayName(String, String) |

It's not trivial to fix these with the existing fast-path operations, because we probably do not want to add a dependency between `Microsoft.Build` and `Microsoft.Build.Utilities.Core` now when it hasn't been there for many years.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.