[WinUI, Shell] Enabling and Disabling ShellElements has no effect
- Dominant language
- C#
- Stars
- 23.3k
- Forks
- 2k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 290
Description
### Description
Wire up Enabling and Disabling on Shell elements on WinUI.
We need to reconcile this behavior with this PR https://github.com/xamarin/Xamarin.Forms/pull/7847
Because currently the IsEnabled implementation seems to be incorrect. IsEnabled should do what IsVisible is promising on #7847 and the current IsEnabled implementation should map to attached properties (Shell.FlyoutItemDisabled, Shell.TabDisabled, etc..)
Currently IsEnabled doesn't even work for the top tabs it only works for bottom tabs and flyout items so the implementation as is is broken
Contributor guide
Research direction
Start by reading the linked PR #7847 and locating the Shell IsEnabled implementation. Compare its behavior for top tabs, bottom tabs, and flyout items with the attached-property behavior mentioned in the issue. Done means enabling and disabling Shell elements works consistently on WinUI without conflicting with the intended IsVisible behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100