dotnet / dotnet/macios

[Tests] Cecil test for manual Equals in bindings

Open
#8,905 1 comment 0 reactions 0 assignees View on GitHub
enhancement iOS macOS
Dominant language
C#
Stars
2.9k
Forks
576
Avg merge
2d 12h
Merged PRs (30d)
123

Description

In investigating this issue:

https://github.com/xamarin/xamarin-macios/issues/8882

it was found that this [PR](https://github.com/xamarin/xamarin-macios/pull/8091) changed Equals behavior enough to cause AVAudioFormat Equals to recurse to stack overflow.

All manual code must have unit tests, and we have a testing hole here.

Given how close we are to WWDC this year, this may not get patched now, but it needs fixed.

> public static bool operator ==
> public static bool operator !=

Also need to be found (cecil) and tested (unit tests), e.g. with `null` values

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.