dotnet / dotnet/macios

[Foundation] Dispose method freeing managed resource

Open
#6,915 0 comments 0 reactions 0 assignees View on GitHub
enhancement iOS macOS
Dominant language
C#
Stars
2.9k
Forks
576
Avg merge
2d 13h
Merged PRs (30d)
96

Description

Following the `Dispose` standard, one shouldn't need to dispose `CancellationTokenSource` in the `InflightData` class here -
```
protected virtual void Dispose (bool disposing)
{
if (disposing) {
if (CancellationTokenSource != null) {
CancellationTokenSource.Dispose ();
CancellationTokenSource = null;
}
}
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.