dotnet / dotnet/macios

[Foundation] The operators in the various NS[Mutable][Ordered]Set[<T>] classes are inconsistent.

Open
#24,430 0 comments 0 reactions 0 assignees View on GitHub
api-bindings enhancement
Dominant language
C#
Stars
2.9k
Forks
576
Avg merge
2d 13h
Merged PRs (30d)
96

Description

Task:

* Look at the various NSSet classes in src/Foundation/
* Make sure the operators treat null/empty/non-empty input the same way. In particular:
* Addition operators must return `null` if and only if both operands are `null`
* Subtraction operators must return `null` if the first operand is `null`, irrespective of what the second operator is.
* The operators must have `[return: NotNullIfNotNull]` attributes when applicable.
* The xml docs should be matching as much as possible.
* Make sure all operators are well tested with unit tests (in the tests/monotouch-test/Foundation directory)

Assign to Copilot once #17285 is complete, to avoid conflicting results.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.