dotnet / dotnet/macios

SecKeychain wrapper methods not marked as obsolete/deprecated

Open
#21,185 4 comments 0 reactions 1 assignee Claimed by @rolfbjarne View on GitHub
api-bindings enhancement
Dominant language
C#
Stars
2.9k
Forks
576
Avg merge
2d 13h
Merged PRs (30d)
96

Description

### Framework version
net8.0-ios

### Description

The `SecKeychain` class has what I believe are convenience methods like `AddGenericPassword`:
https://github.com/xamarin/xamarin-macios/blob/a6b5d22d7420c0fb655026968832fe348dc72c77/src/Security/Items.cs#L511-L532
They call other methods under the hood, like [SecKeychainAddGenericPassword](https://github.com/xamarin/xamarin-macios/blob/a6b5d22d7420c0fb655026968832fe348dc72c77/src/Security/Items.cs#L310). As those methods are deprecated, the "wrapper" method should perhaps also be marked with the obsolete attribute.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.