dotnet / dotnet/macios

[AVFoundation] APIs that take AVFileTypes are bound as string without type safe helper variants

Open
#15,693 1 comment 0 reactions 0 assignees View on GitHub
api-bindings enhancement help wanted
Dominant language
C#
Stars
2.9k
Forks
576
Avg merge
2d 13h
Merged PRs (30d)
96

Description

I am in the process of migrating my apps from legacy Xamarin to .NET6.
Previously, I could use `AVFileType.Mpeg4` to set the property `OutputFileType` of `AVAssetExportSession`.
Now the `AVFileType` type has gone and I have to use `AVFileTypes.Mpeg4.GetConstant()` instead (correct?).

Wouldn't it make sense to then also change the `OutputFileType` (and `SupportedFileTypes`) property types of `AVAssetExportSession` to `AVFileType?` and `AVFileType[]` respectively?

This would then also better match the types documented by Apple: https://developer.apple.com/documentation/avfoundation/avassetexportsession/1387110-outputfiletype
For developers it is not intuitive to use a method on an enum to get the string required.

Related issue:
https://github.com/xamarin/xamarin-macios/issues/8735
https://github.com/xamarin/xamarin-macios/issues/15683

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.