dotnet / dotnet/machinelearning
All DataFrame Elementwise methods uncorrectly work with NULL values
Open
area-DataFrame
untriaged
- Dominant language
- C#
- Stars
- 9.4k
- Forks
- 2k
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 11
Description
**Describe the bug**
PrimitiveColumn ElementwiseEquals, ElementwizeNotEquals and other Elementwise method ignore validity information
For example. this unit test fails as it ElementWizeEquals return true for the first item ( as 0 == null):
```
[Fact]
public void TestElementWiseEquals()
{
PrimitiveDataFrameColumn intColumn1 = new PrimitiveDataFrameColumn("Int1", new int?[] { 0, 2, 3 });
PrimitiveDataFrameColumn intColumn2 = new PrimitiveDataFrameColumn("Int2", new int?[] { null, 2, 3 });
var results = intColumn1.ElementwiseEquals(intColumn2);
Assert.False(results[0]);
}
```
Contributor guide
Assessment
This issue has not been assessed yet.