dotnet / dotnet/machinelearning
MaxSkipNgramLength hard-coded to 10
Open
area-Transforms
enhancement
untriaged
- Dominant language
- C#
- Stars
- 9.4k
- Forks
- 2k
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 11
Description
When trying to produce N-Grams larger than 10, a message is thrown.
https://github.com/dotnet/machinelearning/blob/22342df7fb6d7e42e0d4089c137bf43e8dec7ee9/src/Microsoft.ML.Transforms/Text/NgramTransform.cs#L1043
This is because the `MaxSkipNgramLength` is hard-coded to 10
https://github.com/dotnet/machinelearning/blob/22342df7fb6d7e42e0d4089c137bf43e8dec7ee9/src/Microsoft.ML.Transforms/Text/NgramUtils.cs#L43
Is there a reason why this is the case? Should this be another parameter that the user can set?
Contributor guide
Assessment
This issue has not been assessed yet.