dotnet / dotnet/machinelearning

The example ApplyCustomWordEmbedding is not correct, "product" is not found.

Open
#6,078 0 comments 0 reactions 0 assignees View on GitHub
area-Transforms documentation Priority:3
Dominant language
C#
Stars
9.4k
Forks
2k
Avg merge
2d 20h
Merged PRs (30d)
11

Description

The example ApplyCustomWordEmbedding is not correct, because the method NormalizeText in ML 1.6, has by default keepPunctuation = true, which leads to extracting "product.", not "product". The output is as shown, but the explanation is not, because the 2nd position of the output should be -2, if "product" is considered. I suggest either to remove the "product" row from the custom embeddings, or modify the example accordingly.

---
#### Document Details

⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*

* ID: 80b1e2db-bc79-cead-9e39-ff830d8b211b
* Version Independent ID: c6b67859-e2d9-2b15-8ace-973a164c8ff3
* Content: [TextCatalog.ApplyWordEmbedding Method (Microsoft.ML)](https://docs.microsoft.com/en-us/dotnet/api/microsoft.ml.textcatalog.applywordembedding?view=ml-dotnet)
* Content Source: [dotnet/xml/Microsoft.ML/TextCatalog.xml](https://github.com/dotnet/ml-api-docs/blob/live/dotnet/xml/Microsoft.ML/TextCatalog.xml)
* Product: **dotnet-ml-api**
* GitHub Login: @natke
* Microsoft Alias: **nakersha**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.