dotnet / dotnet/machinelearning

Fix all code that has //REVIEW against it

Open
#3,704 0 comments 1 reaction 0 assignees View on GitHub
area-AutoML enhancement Priority:2
Dominant language
C#
Stars
9.4k
Forks
2k
Avg merge
2d 20h
Merged PRs (30d)
11

Description

C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\ColumnTypeInference.cs(20): // REVIEW: revisit this requirement. Either work for arbitrary number of columns,
C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\PurposeInference.cs(228): // REVIEW: could be improved.
C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\TextFileSample.cs(18): // REVIEW: consider including multiple files via IMultiStreamSource.
C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\TextFileSample.cs(20): // REVIEW: right now, it expects 0x0A being the trailing character of line break.
C:\code\MLNet\src\Microsoft.ML.Auto\ColumnInference\TextFileSample.cs(110): // REVIEW: CreateFromHead still truncates the file before the last 0x0A byte. For multi-byte encoding,
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(205): // REVIEW: this condition can be relaxed if we change the math below to deal with it
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(212): // REVIEW: Is Float accurate enough?
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(218): // REVIEW: review the math below, it only works for positive Min and Max
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(248): // REVIEW: review the math below, it only works for positive Min and Max
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(331): // REVIEW: this condition can be relaxed if we change the math below to deal with it
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(338): // REVIEW: Is Float accurate enough?
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(344): // REVIEW: review the math below, it only works for positive Min and Max
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(366): // REVIEW: review the math below, it only works for positive Min and Max
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\Parameters.cs(451): // REVIEW: Is Float accurate enough?
C:\code\MLNet\src\Microsoft.ML.Auto\Sweepers\SmacSweeper.cs(15): //REVIEW: Figure out better way to do this. could introduce a base class for all smart sweepers,
C:\code\MLNet\src\Microsoft.ML.Auto\Utils\MLNetUtils\ArrayDataViewBuilder.cs(229): // REVIEW: Implement cursor set support.
C:

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.