dotnet / dotnet/machinelearning

SDCA's L1Regularization is badly named since rename

Open
#3,690 0 comments 0 reactions 0 assignees View on GitHub
api-suggestion area-Trainers bug Priority:3
Dominant language
C#
Stars
9.4k
Forks
2k
Avg merge
2d 20h
Merged PRs (30d)
11

Description

A lot of the constants of various learners got renamed to `L1Regularization`. But, in SDCA this isn't actually the `L1Regularization` as the doc also states. It's the ratio of `L1/L2`.

https://github.com/dotnet/machinelearning/blob/5d9e88083a21163258bbeb45597a5f1a95039bc8/src/Microsoft.ML.StandardTrainers/Standard/SdcaBinary.cs#L167-L175

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.