dotnet / dotnet/machinelearning
Clean up Conversions TryParse code.
Open
area-Core
enhancement
Priority:3
- Dominant language
- C#
- Stars
- 9.4k
- Forks
- 2k
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 11
Description
Following the feedback [here](https://github.com/dotnet/machinelearning/pull/2611#issuecomment-465228468) and [here](https://github.com/dotnet/machinelearning/pull/2611#discussion_r258144599), we should do the following for the Conversions code:
* Make `Convert` and `TryParse` consistently named. Either `Convert` and `TryConvert`. Or `Parse` and `TryParse`.
* Clean up the `TryParse` methods so they call `GetValueOrDefault` and don't do unnecessary writes.
Contributor guide
Assessment
This issue has not been assessed yet.