dotnet / dotnet/linker

Cleanup analyzers

Open
#2,355 1 comment 0 reactions 0 assignees View on GitHub
area-Analyzers
Dominant language
C#
Stars
392
Forks
128
Avg merge
2d 10h
Merged PRs (30d)
2

Description

- `COMAnalyzer` uses a link with en-us locale. The locale should be removed so that the user gets redirected to his own culture.
- `SupportedDiagnostics` in ALL analyzers uses `=> ImmutableArray.Create(..)` which will allocate a new array every time the property is accessed. It should be `{ get; } = ImmutableArray.Create(..)` instead.
- `ConfigureGeneratedCodeAnalysis` is passed `GeneratedCodeAnalysisFlags.ReportDiagnostics`, which doesn't make much sense. It should probably be `GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics`. This can be unit tested easily.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.