dotnet / dotnet/linker

Warning validation misses extra warnings

Open
#2,231 0 comments 0 reactions 0 assignees View on GitHub
area-Linker: Tests
Dominant language
C#
Stars
392
Forks
128
Avg merge
2d 10h
Merged PRs (30d)
2

Description

This check is supposed to look for any warnings not expected based on attributes like `ExpectedWarning` and `UnrecognizedReflectionAccessPattern`, but the regex doesn't match our warning strings:

https://github.com/mono/linker/blob/516159bb2b8f090b9c7ac6918c47c9856176d60a/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs#L881

Fixing the regex produces about 80 new test failures due to warnings not expected in existing tests.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.