dotnet / dotnet/linker

Consider how should Scope be treated for UnconditionalSuppressMessage

Open
#2,130 1 comment 1 reaction 0 assignees View on GitHub
area-Linker: Diagnostic
Dominant language
C#
Stars
392
Forks
128
Avg merge
2d 10h
Merged PRs (30d)
2

Description

Scopes are only relevant on the context of global unconditional suppressions -- and they are only ever used to check if a valid scope was used. The original intention of the property was to use it to check whether the target where a suppression is enacted is indeed a type or a member, but because we use [documentation format](https://github.com/dotnet/csharplang/blob/main/spec/documentation-comments.md#id-string-format) on the target this is not needed at all (since the target must be a fully-qualified string prepended with `T`, `M`, `F`, etc. letting it know the parser whether it is a type, method, field, and so on).

This rises the question of whether the `Scope` property of `UnconditionalSuppressMessage` should either be ignored or checked against the target (even though this is currently not needed for the above reasons; although we could expand the understood `Target` strings by using other parsers such as `System.Reflection.Runtime.TypeParsing`).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.