dotnet / dotnet/linker

Insufficient regex escaping in ProcessTypePattern

Open
#1,651 0 comments 0 reactions 0 assignees View on GitHub
area-Linker: Steps
Dominant language
C#
Stars
392
Forks
128
Avg merge
2d 10h
Merged PRs (30d)
2

Description

Backslash is a nested type separator in Cecil (and therefore in IL Link XML), but also has a meaning for regular expressions. I assume things like "match all nested types under Foo.Bar (`Foo.Bar\*`)" don't work right now because we construct a bad regex:

https://github.com/mono/linker/blob/2b04c065c84aa8f30600e3b1989c537fc77de95b/src/linker/Linker.Steps/ProcessLinkerXmlStepBase.cs#L159

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.