dotnet / dotnet/linker

ILLink.LinkAttributes.xml file name is redundant

Open
#1,336 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
392
Forks
128
Avg merge
2d 10h
Merged PRs (30d)
2

Description

The name `ILLink.LinkAttributes.xml` is confusing and redundant. It doesn't appear to follow the other xml file names:

* ILLink.Descriptors.xml
* ILLink.Substitutions.xml

Why do we have "Link" twice in the name? Isn't the `ILLink` prefix enough to specify that this is for "linking"?

Code referencing this file makes it even more confusing. Take for example this MSBuild item/logic:

```xml

```

The double `LinkLink` looks like a copy-paste mistake and one of them should be removed.

cc @vitek-karas @marek-safar

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.